krlmlr / r-appveyor

Tools for using R with AppVeyor (https://appveyor.com)
132 stars 60 forks source link

Set _R_CHECK_FORCE_SUGGESTS_ to FALSE #72

Closed jeroen closed 5 years ago

jeroen commented 8 years ago

CRAN sets _R_CHECK_FORCE_SUGGESTS_=0 in their checks because some suggests might not be available on Windows, but the check still passes. I have the same problem with e.g. protolite: https://ci.appveyor.com/project/jeroenooms/protolite

* checking package dependencies ... ERROR
Package suggested but not available: 'RProtoBuf

I think it would make sense to default to _R_CHECK_FORCE_SUGGESTS_=0 on AV as well?

krlmlr commented 8 years ago

Interesting. But what are the effects if _R_CHECK_FORCE_SUGGESTS_=0 is the default and the tests are not prepared for missing suggested packages? The error message is rather self-explanatory now, and it's easy to fix on the client side.

jeroen commented 8 years ago

If this is the case you get a NOTE (rather than ERROR) during CMD check:

* checking package dependencies ... NOTE
Package suggested but not available for checking: ‘RProtoBuf’

And then if the package is actually required it just errors where the package is used:

Error in library("RProtoBuf") : there is no package called ‘RProtoBuf’

So I think it's rather obvious what the problem is.

krlmlr commented 6 years ago

I'd rather not set this globally, but add a pointer to this setting in the README and suggest using this in a build matrix.

krlmlr commented 6 years ago

OTOH, this is now the default setting for travis::use_tic(), so I guess it should be the default. @jimhester: Do/should we have _R_CHECK_FORCE_SUGGESTS_ off by default on Travis?

krlmlr commented 5 years ago

Fixed by documentation.