krlmlr / r-appveyor

Tools for using R with AppVeyor (https://appveyor.com)
132 stars 60 forks source link

Version of remotes installed by r-appveyor fails with recursive soft dependencies #88

Closed NikNakk closed 5 years ago

NikNakk commented 7 years ago

Installing the current version of dplyr from github fails because of a recursive soft dependency on dbplyr. This is a problem in the version of remotes installed at present. The latest version on github has this fixed (https://github.com/r-pkgs/remotes/issues/31).

As a work-around, I've added - travis-tool.sh install_github r-pkgs/remotes as the first line of my appveyor.yml, but ideally the appveyor script should be updated to use a later version of remotes by default.

krlmlr commented 7 years ago

@gaborcsardi: What are your release plans for the "remotes" package?

gaborcsardi commented 7 years ago

1-2 weeks, it soft-depends on crancache, which I need to finish first.

krlmlr commented 7 years ago

Thanks. @NikNakk: Happy to review a PR that installs from GitHub, we can merge and revert after "remotes" is on CRAN.

gaborcsardi commented 7 years ago

I think in general you are better off with the CRAN version, because remotes will change a lot soon. (After the next CRAN release.)

krlmlr commented 7 years ago

We could pin to a commit for now, by installing r-pkgs/remotes@yxdas.

NikNakk commented 7 years ago

One problem is that to install from github you need remotes. Would the plan to be to install the CRAN version and then use that to install the github version? The zip file from github can't be used directly because the package is in a subdirectory within the zip.

krlmlr commented 7 years ago

I'm fine with this workaround.

hannes commented 7 years ago

have same issue... e.g. https://ci.appveyor.com/project/hannesmuehleisen/MonetDBLite/build/job/m12mm3q2l6l8bv9k

krlmlr commented 7 years ago

Manually installing remotes from GitHub for now in dplyr et al.

hannes commented 7 years ago

yes, that works for me, too. thanks.

krlmlr commented 6 years ago

Is this still a problem?