search

krlmlr / r-appveyor

Tools for using R with AppVeyor (https://appveyor.com)
132 stars 60 forks source link

Should NOT_CRAN=true be the default? #97

Closed yutannihilation closed 5 years ago

yutannihilation commented 6 years ago

I saw some tests in my package skipped on AppVeyor.I suspect that this is because NOT_CRAN=true seems not set.

Travis CI does it here: https://github.com/travis-ci/travis-build/blob/ddc0da6a1231e52708aa88fc71f557ea20cd3b99/lib/travis/build/script/r.rb#L53

(Sorry, I don't have time to confirm the assumption above now. Will check the other day.)

krlmlr commented 6 years ago

Thanks. I haven't thought about this, but you can always set the environment variable yourself in appveyor.yml. Need to rethink if this should be the default.

yutannihilation commented 6 years ago

Thanks! I will set it in my appveyor.yml for now :)

krlmlr commented 5 years ago

Keeping as is.