krlu / fifth-drake

League analytics webapp
http://climb.gg:2222/
Other
0 stars 0 forks source link

Fix for lag when clicking on tags from carousel and bug for selecting… #116

Closed evanfrawley closed 7 years ago

evanfrawley commented 7 years ago

… the dropdown item

3 main bug fixes:

  1. Timeline "lagging" when tag is clicked. Issue with update call in Dashboard. Used same Maybe.withDefault as in the playerdisplay call. Also fixed clickability of box so that when a tag is deleted, that timestamp is not "snapped" to. a. Deleting timestamp makes current playback jitter / jagged for 1 second.
  2. Dropdown select now has a default value. Also implemented a fix so that when a tag is submitted, the tag form gets a blank form state injected.
  3. Changed Animation.queue to Animation.interrupt in Minimap.update. This also makes it so that if you tab out and then back to the same tab, a bunch of animations aren't queued up. The main issue with Animation.queue was that if a player icon travelled a huge distance, aka respawning after dead, backing, TPing, the player would freeze on the x,y that they moved to. Not sure why it was happening, but Animation.interrupt fixed it.

@krlu in terms of the weird timeline bug, I'm having a hard time reproducing it, and I can't exactly figure out what causes it. If a player fiddles with the controls, I think the non buggy state can be returned, let's talk about it soon though. My initial feeling is that its not game breaking so that we should bench it for now.