krlu / fifth-drake

League analytics webapp
http://climb.gg:2222/
Other
0 stars 0 forks source link

Responsive CSS #70

Open evanfrawley opened 7 years ago

evanfrawley commented 7 years ago

Should implement responsive CSS that changes based on the user's screen size. I've done this before using a variety of methods:

evanfrawley commented 7 years ago

example of flexbox + media queries https://codepen.io/chriscoyier/pen/yCeax (and my recommended way of doing this because flexbox is clean af)

mezuzza commented 7 years ago

So that's fine and some of our stuff is actually responsive. The thing is that the people using this are people like Parth. Parth is going to have some massive computer monitor because the main sponsors, the endemic sponsers, are people like BenQ and Acer. They are going to give him big monitors.

That said, yes we should do this, but that requires some design work to understand how it should look.

For now, I'm assuming he uses this in full screen. If he needs to use half the screen, then we'll give him something else. There's also the question of how it should look on say, a phone or tablet.

So to summarize, we need to think of the following: 1) What should it look like when it's wider than tall. 2) What should it look like when it's taller than wide. 3) What should it look like on a small vs big screen. 4) Prioritize snapping to half of a 1920x1080 screen and full screen.

We'll have to come back to this once we've finished our current tasks most likely.