krlvm / AccentColorizer-E11

Accent Colorization for Windows 11 File Explorer Icon Glyphs
https://github.com/krlvm/AccentColorizer
214 stars 8 forks source link

After applying patch sfc scannow report UNABLE to fix "errors" #3

Open FadeMind opened 2 years ago

FadeMind commented 2 years ago

Hello after applying patch sfc /scannow see "damaged" files and it is unable to fix them.

It is any idea "recovery" or rolback changes without re-install whole os? :> Disk is fine, before run app sfc does not report any damage.

Best regards

EDIT

2022-09-02 11:06:03, Info                  CSI    00000297 [SR] Cannot repair member file [l:97]'Core\FileExplorerExtensions\Assets\images\contrast-standard\theme-light\windows.unpinfromhome.svg' of UserExperience-Core, version 10.0.22621.590, arch amd64, nonSxS, pkt {l:8 b:31bf3856ad364e35} in the store, hash mismatch
2022-09-02 11:06:03, Info                  CSI    00000298 Hashes for file member [l:104]'Core\FileExplorerExtensions\Assets\images\contrast-standard\theme-light\windows.unpinfromstartscreen.svg' do not match.
 Expected: {l:32 ml:33 b:34c967b30dab32d927769bd166e5226b87642d3ce9d8845ebf2a4eeaca08fa37}.
 Actual: {l:32 b:8c4a199bd6bb41feda8b820d594f1975e0d1b8e4345d917104f52eabb91c36f4}.
2022-09-02 11:06:03, Info                  CSI    00000299 [SR] Cannot repair member file [l:104]'Core\FileExplorerExtensions\Assets\images\contrast-standard\theme-light\windows.unpinfromstartscreen.svg' of UserExperience-Core, version 10.0.22621.590, arch amd64, nonSxS, pkt {l:8 b:31bf3856ad364e35} in the store, hash mismatch
2022-09-02 11:06:03, Info                  CSI    0000029a Hashes for file member [l:94]'Core\FileExplorerExtensions\Assets\images\contrast-standard\theme-light\Windows.Zip.Action.svg' do not match.
 Expected: {l:32 ml:33 b:c46a5fd4d01dedda4d95bf1fea378d3e8897976e915dad051a8c42e42cef0b7d}.
 Actual: {l:32 b:aa0918c1ac950d0638d17494a212e4e7ddc637d2dc2892a2c365e3b430599432}.

and so on.

IMHO good idea will be backup original "blue" files somwhere in %appdata% before applying patch, and rollback them via flag if needed.

krlvm commented 2 years ago

Does sfc /scannow repair other problems or it refuses to do because of this?

FadeMind commented 2 years ago

I don't have other problems except mismatch checksums for Core\FileExplorerExtensions\Assets\images\ SVG files.

After extract original files from WIM file and replace in dir errors from sfc gone.

Dhyfer1 commented 2 years ago

I don't have other problems except mismatch checksums for Core\FileExplorerExtensions\Assets\images\ SVG files. After extract original files from WIM file and replace in dir errors from sfc gone.

@FadeMind I also have the same problem, which WIM file are you referring to?

krlvm commented 2 years ago

That's the install.wim (or install.esd) from Windows ISO

Dhyfer1 commented 2 years ago

Ok, thanks. @krlvm Can you make AccentColorizer also change the accent color automatically like you did with ACE11?

krlvm commented 2 years ago

It already recolors everything on accent color change since the first version

Dhyfer1 commented 1 year ago

Ok. Hey, I didn't notice, but ACE11 (no matter how many times I change the accent color) doesn't apply the accent color on 4 glyphs in the theme-light folder, they are the glyphs that are highlighted in the image.

image_1

This only happens in the theme-light folder, but in the theme-dark folder these 4 glyphs do change to the selected accent color. This only happens to me or Windows does not allow to color those 4 glyphs?

krlvm commented 1 year ago

I think it just uses different color which we don't look for. Will fix it soon.

Dhyfer1 commented 1 year ago

Okay, then I wait for the next version. Thanks!

krlvm commented 1 year ago

Looks like that glyphs are from the latest Dev build, can you attach one of files you highlighted above?

Dhyfer1 commented 1 year ago

I am a beta channel user. I will not attach 1 file, but I will attach the 4 specific files. Those 4 images appear when you have the "Windows Spotlight" function activated as background image for the desktop, and when Windows is with the light theme.

image_9

Pictures.zip

krlvm commented 1 year ago

Microsoft's being Microsoft. Can't even use the same color consistently. They used #0C59A4 (WHY???) instead of #0078D4 from the accent palette. Resolved in v1.1.1.

Dhyfer1 commented 1 year ago

Great, 👍the new version can now switch to the accent color for these 4 icons in the light theme. Although I notice that the icon for "Switch to next picture" is a bit opaque when you switch to the dark theme, as you can see in the video. Is there anything that can be done about this?

https://user-images.githubusercontent.com/50301201/189500725-f923fa1f-c83e-4052-9e8d-b69f6ee7a9de.mp4

krlvm commented 1 year ago

I think that's why a different color was used. Maybe it should be replaced with a darker color from the palette.

Dhyfer1 commented 1 year ago

Hmm. I have found out what is the cause, as you can see in the attached image, the first two icons belong to the theme-light folder and the last two to the theme-dark folder. As you can see in the image, the first two icons have the same color outline #000000 but the last two do not share the same outline color, because while the "Open" icon uses the color #FDFDFD in its outline, this color is not also used by the "Switch to next picture" icon, and instead uses the color #DEDDDD. This is why the "Switch to next picture" icon looks opaque when using the dark theme.

image_11

Can you do something about it?

krlvm commented 1 year ago

I think it is better to ignore those glyphs at all than dealing with Microsoft lazy developers which can't even use their own color palette consistently

Dhyfer1 commented 1 year ago

LOL😄It's fine, no problem, I can live with that. Windows 11 is inconsistent in many parts. Anyway thanks for the update.

And by the way I also use AcrylicMenus and DragDropNormalizer of your repositories. About AcrylicMenus I am waiting for an update to fix the bug that is mentioned in the open issue, and about DragDropNormalizer I would like that the overlay instead of a semitransparent effect, would have an acrylic effect instead, if possible.

Thanks!

bigplayer-ai commented 1 year ago

Hello after applying patch sfc /scannow see "damaged" files and it is unable to fix them.

It is any idea "recovery" or rolback changes without re-install whole os? :> Disk is fine, before run app sfc does not report any damage.

Best regards

EDIT

2022-09-02 11:06:03, Info                  CSI    00000297 [SR] Cannot repair member file [l:97]'Core\FileExplorerExtensions\Assets\images\contrast-standard\theme-light\windows.unpinfromhome.svg' of UserExperience-Core, version 10.0.22621.590, arch amd64, nonSxS, pkt {l:8 b:31bf3856ad364e35} in the store, hash mismatch
2022-09-02 11:06:03, Info                  CSI    00000298 Hashes for file member [l:104]'Core\FileExplorerExtensions\Assets\images\contrast-standard\theme-light\windows.unpinfromstartscreen.svg' do not match.
 Expected: {l:32 ml:33 b:34c967b30dab32d927769bd166e5226b87642d3ce9d8845ebf2a4eeaca08fa37}.
 Actual: {l:32 b:8c4a199bd6bb41feda8b820d594f1975e0d1b8e4345d917104f52eabb91c36f4}.
2022-09-02 11:06:03, Info                  CSI    00000299 [SR] Cannot repair member file [l:104]'Core\FileExplorerExtensions\Assets\images\contrast-standard\theme-light\windows.unpinfromstartscreen.svg' of UserExperience-Core, version 10.0.22621.590, arch amd64, nonSxS, pkt {l:8 b:31bf3856ad364e35} in the store, hash mismatch
2022-09-02 11:06:03, Info                  CSI    0000029a Hashes for file member [l:94]'Core\FileExplorerExtensions\Assets\images\contrast-standard\theme-light\Windows.Zip.Action.svg' do not match.
 Expected: {l:32 ml:33 b:c46a5fd4d01dedda4d95bf1fea378d3e8897976e915dad051a8c42e42cef0b7d}.
 Actual: {l:32 b:aa0918c1ac950d0638d17494a212e4e7ddc637d2dc2892a2c365e3b430599432}.

and so on.

IMHO good idea will be backup original "blue" files somwhere in %appdata% before applying patch, and rollback them via flag if needed.

How did you fix this?

FadeMind commented 1 year ago

@bigplayer-ai acronis image or reinstall

bigplayer-ai commented 1 year ago

@bigplayer-ai acronis image or reinstall

What can I do without resetting my whole pc :( I just resetted my PC only because beautysearch affect my sfc/scannow. I don't want to reinstall again because of this now :(

FadeMind commented 1 year ago

I tried rollback originals from backup SVG files, but SFC still freak out about them. So clean sfc solution is like I said.

bigplayer-ai commented 1 year ago

clean sfc solution

How to do that?

FadeMind commented 1 year ago

@bigplayer-ai Acronis Image BEFORE applying patches OR reinstall System cause overwrite files to originals via copy paste did not resolve sfc scan. Thats it.

bigplayer-ai commented 1 year ago

How can I have Acronis Image backup? I am going to reset/reinstall my PC again only because of this. I want to have acronis image backups every time. How can I do that?

FadeMind commented 1 year ago

https://www.google.com/search?q=create+acronis+image+winpe