krlvm / AccentColorizer

Recolorize Win32 controls in-memory with accent color without patching theme
MIT License
354 stars 12 forks source link

App doesn't colorize controls if the scaling is more than 125% #1

Closed rounk-ctrl closed 2 years ago

rounk-ctrl commented 2 years ago

I think opening the theme data with OpenThemeDataForDpi would work.

krlvm commented 2 years ago

This is a very big problem, last time it could not be fixed, even with OpenThemeDataForDpi

https://github.com/valinet/ExplorerPatcher/discussions/436

krlvm commented 2 years ago

Strange - the latest x64 build works on 22000, 150% and 250% scaling.

krlvm commented 2 years ago

Also checked on 1709 and can't reproduce, I'm pretty sure this should be definitely bugged though, because the most of classes have different bitmaps per DPI value. Can you provide details?

rounk-ctrl commented 2 years ago

Well I tried it on nickel and it didnt work there

krlvm commented 2 years ago

Windows 11 RP / Beta (Build 22621), 175% and 175% set as custom scale factor

The only thing I noticed, that after I rolled back to my preferred 125%, everything became blue, but after I restarted the application, everything became green again

1 2

rounk-ctrl commented 2 years ago

oh but shouldn't the app automatically do it tho as it is running in the background ig respond to WM_DPICHANGED message

krlvm commented 2 years ago

Didn't think about it. So everything worked for you after the restart? If yes, then I'm pleasantly surprised, because for some reason it caused problems last time.

krlvm commented 2 years ago

I wonder if this will all work with two monitors with different DPI each.

rounk-ctrl commented 2 years ago

Didn't think about it. So everything worked for you after the restart? If yes, then I'm pleasantly surprised, because for some reason it caused problems last time.

yea

krlvm commented 2 years ago

Very glad to hear!

rounk-ctrl commented 2 years ago

Also shouldn't a tray icon be ideal? I mean it runs in the background anyways.

krlvm commented 2 years ago

Initially, I wanted to make a small program that just runs in the background and does not show any signs of life, although there is a room for improvements: a tray icon, a window for choosing colors - if you are interested in this, you can create a new project based on this - I need just figure out how to extract the main code from here so that it can be updated independently of the UI as a git submodule.

rounk-ctrl commented 2 years ago

Ok