krmaxwell / maltrieve

A tool to retrieve malware directly from the source for security researchers.
GNU General Public License v3.0
563 stars 183 forks source link

Updated code breaks CRITs integration #164

Closed webstergd closed 9 years ago

webstergd commented 9 years ago

The updated code for the configuration object and domain logging breaks the integration.

I am testing a patch and will submit a pull request shortly.

krmaxwell commented 9 years ago

Hrm, that's odd since I'm running the code and it's uploading correctly to my CRITs instance. Wonder what's different.

webstergd commented 9 years ago

In my setup that caused self.crits to be equal to True

For some reason without that verify it breaks. Check your setup and look at domains and relationships. It will upload the samples but fails on the domain and creating the relationship. (I am using a valid ssl)

krmaxwell commented 9 years ago

Fixed in #165