krmaxwell / maltrieve

A tool to retrieve malware directly from the source for security researchers.
GNU General Public License v3.0
562 stars 184 forks source link

traceback when urlopen returns error #36

Closed fropert closed 10 years ago

fropert commented 10 years ago

Hi,

http://vxvault.siri-urz.net/URL_List.php is http errror code 500 at the time of writing. It makes maltrieve.py tracebacks:

2014-03-26 12:09:49 -1216760128 urlopen() returned error Internal Server Error

Traceback (most recent call last): File "maltrieve.py", line 275, in main() File "maltrieve.py", line 236, in main for url in get_URL('http://vxvault.siri-urz.net/URL_List.php'): TypeError: 'bool' object is not iterable

Cheers, pello

krmaxwell commented 10 years ago

urlopen no longer in use, replaced with requests and better error handling also added