search

krmaxwell / maltrieve

A tool to retrieve malware directly from the source for security researchers.
GNU General Public License v3.0
562 stars 184 forks source link

Configuration file doesn't seem to do anything... #57

Closed sroberts closed 9 years ago

sroberts commented 10 years ago

Testing things out the maltrieve.cfg didn't seem to successfully set all options. Specifically it causes an error in generating the dumpdir, and it always defaults to /tmp/malware.

Am I missing something?

krmaxwell commented 10 years ago

Dunno, will check.

krmaxwell commented 10 years ago

Pretty sure this will happen if the directory doesn't already exist. Should we create it or just document that it should exist?

sroberts commented 10 years ago

I say just create it.

As the great software developer Drake once said: YOLO.

krmaxwell commented 10 years ago

So it turns out the code to create it is there. Not sure yet what's causing this to break.

kevthehermit commented 9 years ago

I think its this - 

d = tempfile.mkdtemp(dir=cfg['dumpdir'])

this generates this error if the dir doesn't already exist

2014-09-28 11:14:33 139749181601536 Could not open archive for writing ([Errno 2] No such file or directory: 'archive/tmpIUwxjK'), using default

should be easy to put a os.makedirs just before this