search

krober10nd / SeismicMesh

2D/3D serial and parallel triangular mesh generation tool for finite element methods.
https://seismicmesh.readthedocs.io/
GNU General Public License v3.0
126 stars 32 forks source link

can't install seismicmesh with python 3.8.1+ #158

Closed nschloe closed 3 years ago

nschloe commented 3 years ago 
import sys

print(sys.version_info)
print(sys.version_info > (3, 8))
sys.version_info(major=3, minor=8, micro=6, releaselevel='final', serial=0)
True
nschloe commented 3 years ago

This also means that SM isn't properly tested with all supported Python versions.

krober10nd commented 3 years ago

Actually, I can't test 3.9 because of segyio. And I put in a stop to prevent installation for that exact reason. I'm not sure what' the deal with 3.8.1.

krober10nd commented 3 years ago

I'll put in some more builds into the CI machine.

nschloe commented 3 years ago

Right now, you're also blocking 3.8.1 (which is > (3,8)).

krober10nd commented 3 years ago

oh I see your point. I was going to test other versions of Python any way too. I'll fix both.

nschloe commented 3 years ago

Actually, I can't test 3.9 because of segyio

It's also my experience that Python 3.9 is a bit early for testing. Many packages aren't cached yet and tests take forever, so I still leave that out. Your mileage may vary.

krober10nd commented 3 years ago

Yea, it is a bit early.

Eventually I'll switch over to Github workflows with the hope that they don't start charging.

krober10nd commented 3 years ago

You should be able to install now with 3.8.1. It's also tested on the CI system along with version 3.6.5.

nschloe commented 3 years ago

Fix confirmed.