support for python 3.9 - Githubissues

krober10nd / SeismicMesh

2D/3D serial and parallel triangular mesh generation tool for finite element methods.

https://seismicmesh.readthedocs.io/

GNU General Public License v3.0

123 stars 32 forks source link

support for python 3.9 #202

Closed krober10nd closed 3 years ago

krober10nd commented 3 years ago

removes installation blocker for python3.9
localizes segyio dependency installation into the only local function that uses it.

nschloe commented 3 years ago

Make the dependency optional, too. See https://github.com/nschloe/meshio/blob/main/setup.cfg#L44.

nschloe commented 3 years ago

You may want to lose python_requires=">=3.0" from setup.py too. (It's already in setup.cfg.)

krober10nd commented 3 years ago

hm, no luck with making segyio optional. When I put it into the setup.cfg file like you showed I get

WARNING: SeismicMesh 3.5.0 does not provide the extra 'all'

so I put it into the setup.py file but same issue.

nschloe commented 3 years ago

so I put it into the setup.py file but same issue.

setup.py overrides setup.cfg. Try putting it all into setup.cfg.

krober10nd commented 3 years ago

alright, I created three optionals: io, benchmarking, and all which is a combination of io and benchmarking. I didn't want to add the other packages that I use for mesh generation comparison into common installs as these require other additional third party packages (like gmsh). I put all these optionals in setup.cfg and tested this on a virtual env with python 3.9. I also added another CI build for 3.9.

I plan to improve io capabilities here in some time.