search

krober10nd / SeismicMesh

2D/3D serial and parallel triangular mesh generation tool for finite element methods.
https://seismicmesh.readthedocs.io/
GNU General Public License v3.0
129 stars 33 forks source link

pyamg == 4.0.0? #217

Closed nschloe closed 3 years ago

nschloe commented 3 years ago

The pyamg dependency is fixed to 4.0.0. Why?

krober10nd commented 3 years ago

Some users were reporting the call to the AMG segfaulting on Ubuntu systems. Never had this issue on Mac (using the same script)

nschloe commented 3 years ago

Hm, that's weird. Perhaps you should exclude certain versions then. Fixing the dependency makes it difficult to work with newer pyamg versions (pip installs everything globally).

krober10nd commented 3 years ago

yea, I'll try that after I get workflows working. And pinning versions is not a good idea, I agree.

krober10nd commented 3 years ago

ah the other reason I had fixed the version of pyamg, is more recent versions of pyamg were causing my Laplacian smooths to produce widely different total number of vertices and elements and thus some tests were failing that had previously always worked.

I'll unpin the version in #216 and we'll see where it goes wrong.

krober10nd commented 3 years ago

No longer pinned now #216