search

krober10nd / SeismicMesh

2D/3D serial and parallel triangular mesh generation tool for finite element methods.
https://seismicmesh.readthedocs.io/
GNU General Public License v3.0
127 stars 33 forks source link

test coverage not properly configured? #31

Closed nschloe closed 4 years ago

nschloe commented 4 years ago

When looking at the coverage data, I only see a few files accounted for:

screenshot

It seems that there is something misconfigured. Could you look into it?

krober10nd commented 4 years ago

Indeed, the CI system was pointed to master which I don't use. I switched it to my default par3d branch and now the coverage report is showing a much more accurate depiction of what the tests pass through.

Screen Shot 2020-08-30 at 5 50 54 PM
nschloe commented 4 years ago

When you click on any of the files in codecov, you get a 404. I think you can remove most of the codecov config to fix this.

krober10nd commented 4 years ago

I see. I fixed that by making sure the codecov didn't "fix paths"

Check it out now:

https://codecov.io/gh/krober10nd/SeismicMesh/src/par3d/SeismicMesh/generation/mesh_generator.py

nschloe commented 4 years ago

Looking good now.