search

krobertson / deb-s3

Easily create and manage an APT repository on S3 -- NO LONGER MAINTAINED
MIT License
482 stars 148 forks source link

--fail-if-exists has no effect #136

Closed pbeeson closed 6 years ago

pbeeson commented 6 years ago

fail-if-exists seems to not have any effect. The package just uploads as normal.

jenkins@rosie:~/jobs/Craftsman/workspace/craftsman_dev/debs$ deb-s3 upload --fail-if-exists  --gpg-options="--digest-algo SHA256" --bucket craftsman-debs ros-kinetic-trac-ik_1.4.10-0xenial_amd64.deb 
>> Retrieving existing manifests
>> Examining package file ros-kinetic-trac-ik_1.4.10-0xenial_amd64.deb
>> Uploading packages and new manifests to S3
   -- Transferring pool/r/ro/ros-kinetic-trac-ik_1.4.10-0xenial_amd64.deb
   -- Transferring dists/stable/main/binary-amd64/Packages
   -- Transferring dists/stable/main/binary-amd64/Packages.gz
   -- Transferring dists/stable/main/binary-i386/Packages
   -- Transferring dists/stable/main/binary-i386/Packages.gz
   -- Transferring dists/stable/main/binary-armhf/Packages
   -- Transferring dists/stable/main/binary-armhf/Packages.gz
   -- Transferring dists/stable/Release
   -- Transferring dists/stable/Release.gpg
>> Update complete.
jenkins@rosie:~/jobs/Craftsman/workspace/craftsman_dev/debs$ deb-s3 upload --fail-if-exists  --gpg-options="--digest-algo SHA256" --bucket craftsman-debs ros-kinetic-trac-ik_1.4.10-0xenial_amd64.deb 
>> Retrieving existing manifests
>> Examining package file ros-kinetic-trac-ik_1.4.10-0xenial_amd64.deb
>> Uploading packages and new manifests to S3
   -- Transferring pool/r/ro/ros-kinetic-trac-ik_1.4.10-0xenial_amd64.deb
   -- Transferring dists/stable/main/binary-amd64/Packages
   -- Transferring dists/stable/main/binary-amd64/Packages.gz
   -- Transferring dists/stable/main/binary-i386/Packages
   -- Transferring dists/stable/main/binary-i386/Packages.gz
   -- Transferring dists/stable/main/binary-armhf/Packages
   -- Transferring dists/stable/main/binary-armhf/Packages.gz
   -- Transferring dists/stable/Release
   -- Transferring dists/stable/Release.gpg
>> Update complete.
agimenez commented 6 years ago

It worked for me, provided that the actual contents of the package are different. Have you tried to actually generate a new package with same version, but different contents?

pbeeson commented 6 years ago

I believe my testing was building packages with identical content. This "feature" of only failing if the files exist, but are different wasn't clear in the documentation.

agimenez commented 6 years ago

@pbeeson can you check please if the PR matches your expectations?

Thanks!

pbeeson commented 6 years ago

Looks good.

agimenez commented 6 years ago

@krobertson care to take a look, please?

Thanks.