Change content-type for Packages and Release files to text/plain

krobertson / deb-s3

Easily create and manage an APT repository on S3 -- NO LONGER MAINTAINED

MIT License

482 stars 148 forks source link

Change content-type for Packages and Release files to text/plain #83

Closed rmldsky closed 9 years ago

rmldsky commented 9 years ago

This will solve the issue #78 . I saw similar change for content-types were done previously in PR #28, not sure when it got lost. Also I have used UTF-8 instead us-ascii as ASCII is a sub-set of UTF-8 anyway, plus it might be that maintainer name can include some special characters (ą, ł, ę, etc.). But if I am missing something here I might set it to ASCII. I have tested in on S3 bucket and works as expected (files display in the browser instead of being downloaded).

rmldsky commented 9 years ago

I dug deeper to discover this: https://github.com/krobertson/deb-s3/commit/6c825e9059272afae0dd3199561607799ba2389f not sure what was the UTF-8 issue then. If you remember and can check/confirm if my PR does not introduce it back it would be great. Might be that charset=UTF-8 is the right choice here after all.

krobertson commented 9 years ago

Thanks!