krogk / AgroPi

Automated cultivation system for plants & mushrooms using Raspberry Pi
https://www.facebook.com/AgroPiOfficial
GNU General Public License v3.0
23 stars 11 forks source link

Actuaction - No Control Flags [CPP & Web] #29

Closed krogk closed 3 years ago

krogk commented 3 years ago

Problem Currently no set of control flags and statements supporting these exists

Solution A structs in controller object holding:

  1. Force Flags - Force is going to turn the actuator and ignore heuristics like
  2. Enable heuristics - Enable Heuristics

If 2. Heuristic enable flag is disabled for particular actuator then Force flag is going to act like on and off switch.

  1. A set of on and off buttons on the website sending appropriate operation code and value on targets update.

Additional context A detailed set of requirements must be created.

krogk commented 3 years ago

Implemented in 78f01b468e57e9e33bd845090bab05f4cd63a354 But that patch had many shortcomings mainly web server bugs and unnecessary execution due to not checking current state of actuators.

krogk commented 3 years ago

Fixed in eb3189d40ee8903e9e15c79e68cbf8187e9acc7d Play tested and seems to be working now See commit for details