search

krogsgard / happy

Github repository for the Happy theme
27 stars 7 forks source link

Create theme settings #2

Open krogsgard opened 12 years ago

krogsgard commented 12 years ago

Need to create theme settings for a few features:

1) enable archives or excerpts 2) enable menu toggles (choose which menus receive toggle) 3) enable home feature area 4) some other, more typical stuff

bryceadams commented 11 years ago

Do you plan on using an options framework or building from scratch?

krogsgard commented 11 years ago

@bryceadams thanks for checking in, Bryce : ) I'm probably going to roll my own based in large part on Tom McFarlin's boilerplate https://github.com/tommcfarlin/WordPress-Settings-Sandbox Though it will be much simpler. I'd like for most of the theme settings to be configurable through the customizer.

mattyza commented 11 years ago

@krogsgard The code structure in Tom's sandbox example looks nice and clean. A bit of repetition, but it's an example boilerplate so... :)

One thing I did notice is that all options are stored in individual rows in the options table. While this is done, it's not ideal (all should be in a single row, rather, in a serialised array).

You could create a function/method to get, format and cache the settings as well, which would save both on database storage and be useful and scalable in terms of the PHP involved. :)

JamesGeiger commented 11 years ago

Hi,

I just wanted to weigh in and say that the less theme options the better. I think since it is a base theme, too many would be overkill. You want people to focus on the responsiveness, not the options after all :-)