search

kroimon / ExpirableItemDictionary

https://www.nuget.org/packages/ExpirableItemDictionary/
10 stars 4 forks source link

.NET Core support missing #1

Closed sandromastronardi closed 3 years ago

sandromastronardi commented 3 years ago

Hi, the library isn't supporting .NET Core yet (or .NET Standard)... with .NET moving to .NET 5 this might be very useful...

kroimon commented 3 years ago

Pull requests for this would be very welcome!

sandromastronardi commented 3 years ago

I would have done that if it wasn't very intrusive... the csproj setup is quite different, so needs to be replaced and then I don't know what you still need from it... it's not so difficult, just a big change to do on my own on someone else's project ;-)

sandromastronardi commented 3 years ago

Which DotnetFramework versions is it currently supporting? can't see that in the project file...

kroimon commented 3 years ago

The library is currently targeting .NET Framework 3.5 as a common minimum as can be seen in ExpirableItemDictionary.csproj (search for TargetFrameworkVersion).

kroimon commented 3 years ago

Hints on how to create multi-platform nuget packages can be found here at Microsoft Docs and probably here and/or here.

I never did that myself and currently lack the time of implementing this, so I would greatly appreciate pull requests.

sandromastronardi commented 3 years ago

hmm, ok, i missed the targeting somehow... Ok, so .NET 3.5, .NET Standard 2.0, .NET Core 2.1 and .NET Core 3.1 are ok for you?

sandromastronardi commented 3 years ago

PR Ready

kroimon commented 3 years ago

Solved in #2. Thanks again for your help!