search

kroitor / asciichart

Nice-looking lightweight console ASCII line charts ╭┈╯ for NodeJS, browsers and terminal, no dependencies
MIT License
1.87k stars 94 forks source link

Clean up Python code. #28

Closed neighthan closed 4 years ago

neighthan commented 5 years ago

This removes a handful of unnecessary uses of abs, float, and int and also puts in a check to ensure that the maximum value for the plot is greater than the minimum value. No functionality is changed here.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 3be1dff10c2e56bfd5a533d711e56c6a4a5c8e2a on neighthan:python_cleanup into 714e0570022fdeeed910875bf374b951c1388cef on kroitor:master.

neighthan commented 5 years ago

Note that PR #14 does part of the same work that this PR does, but I clean up several more things. If this PR is merged, that one should be closed (the only difference is in the naming that we chose to keep; I kept min2 and max2 while the other PR kept intmin2 and intmax2).

kroitor commented 5 years ago

@neighthan awesome! Thx so much again!