Ability to ignore manual data

krokyze / FitKit

Flutter plugin for reading health and fitness data. Wraps HealthKit on iOS and GoogleFit on Android.

BSD 2-Clause "Simplified" License

98 stars 73 forks source link

Ability to ignore manual data #29

Closed AmitaiMazliah closed 4 years ago

krokyze commented 4 years ago

As FitData already contains userEntered flag I feel ignoring manual data should be handled on application side. If you have other reasons for this feel free to reopen this pull request and explain the reasons why.

AmitaiMazliah commented 4 years ago

I don’t think you are right. Let me explain why. Looking at a normal system with SQL database Will you query the entire table and than filter in the code? Or will you query the database with a filter?

Databases are made to be queried because they do it faster than average code. And it’s less data going tho the system.

Your opinion?

krokyze commented 4 years ago

I completely understand your point of view, if similar functionality would be supported by GoogleFit I would definitely accept this pull request, but currently this breaks the limit functionality on Android side.

In case the last FitData would be manual entry but the previous one non-manual.

iOS would return the previous one.
Android would return nil.

As I'm trying to keep package usage experience as much as I can the same on both platforms, I don't want to add this.