search

krokyze / FitKit

Flutter plugin for reading health and fitness data. Wraps HealthKit on iOS and GoogleFit on Android.
BSD 2-Clause "Simplified" License
98 stars 73 forks source link

Apple HealthKit data types #5

Closed PaNaVTEC closed 5 years ago

PaNaVTEC commented 5 years ago

Hi,

I was wondering if there is any plan to support the data types that Apple supports even if they are not supported by google fit:

https://developer.apple.com/documentation/healthkit/data_types

For example, 

static let waistCircumference: HKQuantityTypeIdentifier

Thanks.

krokyze commented 5 years ago

Hey @PaNaVTEC

Yes definitely, I just currently haven't decided how to handle unsupported data types and had time to do it, so if you're interested you can definitely make a pull request ;)

PaNaVTEC commented 5 years ago

@krokyze I can take a look on how to implement it, do you have any idea/preference? I was thinking on returning something like an Option<T>, so if we publish all the possible datatypes it can return Some(measure) or Nothing.

krokyze commented 5 years ago

Hey @PaNaVTEC

Sorry for the late reply. Yes Optional sounds like the right choice. I will close this issue, feel free to open new one ;)