Closed sm-stack closed 3 hours ago
[!IMPORTANT]
Review skipped
Auto reviews are disabled on base/target branches other than the default branch.
🗂️ Base branches to auto review (2)
* dev * mainPlease check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Maybe we don't need MaybeAddFeeRecipientsToStatesAffected
function anymore..? I can't understand why the inner logic is only applied when the tx is not deposit tx (I think the reverse is correct), and what the purpose of that function is. @Pangssu can you check if the function can be removed or not?
Looks like it's used inside scroll zkEVM prover? I guess we can remove the whole api_blocktrace.go
and relevent logging functions after we transition to zkVM proving system (or delete it now, if it's not used in kroma-prover)
Looks like it's used inside scroll zkEVM prover? I guess we can remove the whole
api_blocktrace.go
and relevent logging functions after we transition to zkVM proving system (or delete it now, if it's not used in kroma-prover)
I think it's better to remove thoes parts only necessary for zkEVM prover after the transition to zkVM, thanks!
This PR is to change L1Block and fee recipient addresses at MPT migration fork.
You can test this by spinning up a Kroma devnet as follows:
kroma
.smstack15/geth:mpt-a61dbd0ba
(temp image for testing) atdocker-compose.yml
."l2GenesisKromaMPTTimeOffset": "0x4"
and spin up the devnet.Note that the l1 fee will not be accrued in this devnet, since
L1Block
address is not yet changed so that the fee scalars are recognized as 0. The l1 fee part is tested locally and checked that l1 fee is normally accrued if L1Block address is not changed after mpt migration.