kroma-network / kroma

A developer-friendly, rollup-based Ethereum Layer 2 solution that offers low fees and EVM equivalence.
Other
153 stars 77 forks source link

chore: set Ecotone time for Kroma mainnet #298

Closed 0xHansLee closed 3 months ago

0xHansLee commented 3 months ago

Set Ecotone activation time for Kroma mainnet. The activation time is Mon Apr 22 2024 08:00:00(unix timestamp 1713772800).

Summary by CodeRabbit

coderabbitai[bot] commented 3 months ago

Walkthrough

The recent updates involve two main changes. Firstly, the EcotoneTime value in the Mainnet configuration has been changed to a specific timestamp, indicating a scheduled event or update. Secondly, the version of the Docker image used in the development network has been upgraded to enhance stability or introduce new features, impacting the associated Geth version used in the network.

Changes

Files Change Summary
op-node/chaincfg/chains.go,
op-node/chaincfg/chains_test.go
Updated EcotoneTime value in Mainnet configuration from nil to 1713772800.
ops-devnet/docker-compose.yml Updated Docker image version for l2 service from v0.5.0-rc.4 to v0.5.0, affecting kromanetwork/geth version.

Recent Review Details **Configuration used: CodeRabbit UI**
Commits Files that changed from the base of the PR and between 8775218482d910c2c07f56215651b5bdb84aaf9b and 59b0a16d4a9f66750c2e1734a725665c907463e4.
Files selected for processing (3) * op-node/chaincfg/chains.go (1 hunks) * op-node/chaincfg/chains_test.go (1 hunks) * ops-devnet/docker-compose.yml (1 hunks)
Files skipped from review due to trivial changes (1) * ops-devnet/docker-compose.yml
Additional comments not posted (2)
op-node/chaincfg/chains.go (1)
`44-44`: Update to `EcotoneTime` correctly sets the Unix timestamp for the Kroma mainnet Ecotone upgrade. The use of `u64Ptr` is consistent with other similar configurations in the file.
op-node/chaincfg/chains_test.go (1)
`71-71`: Update to `EcotoneTime` in the test configuration correctly mirrors the main configuration update, ensuring consistency in testing the new settings for the Kroma mainnet.
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger a review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.