Closed seolaoh closed 5 months ago
[!IMPORTANT]
Auto Review Skipped
Auto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings.
Please check the settings in the CodeRabbit UI or the
.coderabbit.yaml
file in this repository. To trigger a single review, invoke the@coderabbitai review
command.You can disable this status message by setting the
reviews.review_status
tofalse
in the CodeRabbit configuration file.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Add a validation process for _minSlashingAmount
to constructor.
Add a validation process for
_minSlashingAmount
to constructor.
What do you mean for a validation process? To check what?
Add a validation process for
_minSlashingAmount
to constructor.What do you mean for a validation process? To check what?
Ignore it. I realised that it can't check it in the AssetManager contract. _minSlashingAmount <= ValidatorManager.MIN_START_AMOUNT
Description
Implemented validator system upgrade from using
ValidatorPool
to usingValidatorManager
inColosseum
.Since some bugs are found in
ValidatorManager
andAssetManager
, fixed them appropriately. I recommend to review this PR commit by commit because it includes some refactoring.