kroma-network / kroma

A developer-friendly, rollup-based Ethereum Layer 2 solution that offers low fees and EVM equivalence.
Other
161 stars 82 forks source link

feat(contracts): implement vesting wallet #335

Closed seolaoh closed 3 months ago

seolaoh commented 3 months ago

Description

Implemented KromaVestingWallet contract.

coderabbitai[bot] commented 3 months ago

Walkthrough

This update introduces new functionalities and modifications across various files, including the addition of multiple test cases for KromaVestingWallet, updates to deployment logic for governance token proxies, and changes to the deploy utility functions. It also adds deployment scripts for investor and team vesting wallets while updating the configuration and storage layout of the KromaVestingWallet contract.

Changes

Files / Path Change Summary
packages/contracts/.gas-snapshot Added test cases covering initialization, token migration, releasing tokens, setting beneficiaries, and ownership checks.
packages/contracts/.storage-layout Added new storage variables for KromaVestingWallet contract to manage vesting and ownership details more effectively.
.../contracts/test/KromaVestingWallet.t.sol Introduced new test cases for the KromaVestingWallet contract to ensure full coverage of its functionality.
packages/contracts/contracts/universal/KromaVestingWallet.sol Added specifications for handling fund vesting over time, with new vesting and beneficiary functionalities.
.../deploy/L1/017-L1GovernanceTokenProxy.ts Updated deployment logic to use the deployer as the proxy admin instead of a configuration parameter.
.../deploy/L1/019-L1GovernanceToken.ts Replaced deploy function with deployAndUpgradeByDeployer, added initArgs, and updated admin settings for deployment.
.../deploy/L2/011-GovernanceTokenProxy.ts Modified deployment logic to assign deployer as the admin instead of a configured owner.
.../deploy/L2/013-GovernanceToken.ts Updated deployment functions to handle new deployment and upgrading logic, ensuring correct contract initialization.
packages/contracts/deploy/L2/104-InvestorVestingWallet.ts Added new deployment script to deploy and configure the Investor Vesting Wallet contract.
packages/contracts/deploy/L2/105-TeamVestingWallet.ts Added a new deployment script for the Team Vesting Wallet contract, with associated initialization and verification steps.
packages/contracts/src/deploy-config.ts Updated configuration interface to include new properties related to investor and team vesting wallets.
packages/contracts/src/deploy-utils.ts Split deploy function into two separate functions (deploy and deployAndUpgradeByDeployer) for clearer deployment logic.

Sequence Diagram(s)

Vesting Flow Diagram

sequenceDiagram
    participant User
    participant ContractOwner
    participant KromaVestingWallet
    participant ERC20Token
    participant ETHVault

    User->>ContractOwner: Set up vesting wallet
    ContractOwner->>KromaVestingWallet: Initialize with start, duration, cliffDivider, vestingCycle
    KromaVestingWallet->>ERC20Token: Request token approval
    ERC20Token-->>KromaVestingWallet: Approve tokens
    User->>KromaVestingWallet: Check balance and vesting status
    alt Token Vesting
        KromaVestingWallet->>ERC20Token: Release vested tokens
        ERC20Token-->>User: Transferred vested tokens
    end
    alt ETH Vesting
        KromaVestingWallet->>ETHVault: Release vested ETH
        ETHVault-->>User: Transferred vested ETH
    end
    ContractOwner->>KromaVestingWallet: Set new beneficiary
    KromaVestingWallet->>User: Update beneficiary status

Deployment Flow Diagram

sequenceDiagram
    participant Deployer
    participant DeploymentScript
    participant ProxyAdmin
    participant ContractInstance
    participant ContractVariables

    Deployer->>DeploymentScript: Run deployment script
    DeploymentScript->>ProxyAdmin: Deploy ProxyAdmin
    DeploymentScript->>ContractInstance: Deploy implementation contract
    DeploymentScript->>ContractVariables: Initialize variables (beneficiary, start, duration, etc.)
    DeploymentScript->>ProxyAdmin: Assign ProxyAdmin to contract
    ProxyAdmin-->>DeploymentScript: Confirm assignment
    DeploymentScript-->>Deployer: Deployment completed

[!TIP]

Early access features: enabled We are currently testing the following features in early access: - **OpenAI `gpt-4o` model for code reviews and chat**: OpenAI claims that this model is better at understanding and generating code than the previous models. We seek your feedback over the next few weeks before making it generally available. Note: - You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file. - Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide feedback and report issues. - OSS projects are currently opted into early access features by default.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.