kroma-network / tachyon

Modular ZK(Zero Knowledge) backend accelerated by GPU

MIT License

7.77k stars 231 forks source link

test: add `no_zk` and `verify` flag for circom benchmarking #423

Closed TomTaehoonKim closed 4 months ago

TomTaehoonKim commented 4 months ago

Description

This PR adds a no_zk and verify flag for circom benchmarking.

With the no_zk flag, you can create proof without zk. By default zk is enabled. You can use this flag in case you want to compare the proof with rapidsnark. For benchmarking proving speed, we do not need to verify proof everytime. So, verify flag is added in case you want to verify the proof with public inputs.

chokobole commented 4 months ago

feat(zk/r1cs): add default constructor for groth16 proof Please change scope zk/r1cs to zk
test: add no_zk flag for circom benchmark Please add scope circom.

chokobole commented 4 months ago

Could you please add verify flag, too? I believe there's no need to verify every time!