kroma-network / tachyon

Modular ZK(Zero Knowledge) backend accelerated by GPU

MIT License

7.77k stars 231 forks source link

feat(math): impl remove zeros for sparse univariate poly #430

Closed batzor closed 3 months ago

batzor commented 4 months ago

Description

Change RemoveHighDegreeZeros() to RemoveZeros() in univariate spare polynomial
Enforce clean construction of polynomials. After this change, all poly operations are expected to operate on clean polynomials and output clean polynomials.

TomTaehoonKim commented 3 months ago

@batzor For the second commit, I can agree for the sparse coefficients but not with the dense coefficients. What's the motivation behind reducing the usage of remove high degree zeros for dense coefficients?

batzor commented 3 months ago

@TomTaehoonKim Indeed, the RemoveHighDegreeZeros() is low cost operation so it's not that necessary but I just did the change for the sake of consistency and clarity.

batzor commented 3 months ago

@chokobole I reordered the commits as you requested. Hope its more clear now;;