Closed chokobole closed 3 weeks ago
The motivation behind this PR is to simplify the naming convention for supporting halo2 and log_derivative_halo2 lookups. Previously, we would need to create 8 C APIs as follows:
halo2
log_derivative_halo2
tachyon_halo2_bn254_gwc_halo2_prover
tachyon_halo2_bn254_gwc_log_derivative_halo2_prover
tachyon_halo2_bn254_shplonk_halo2_prover
tachyon_halo2_bn254_shplonk_log_derivative_halo2_prover
tachyon_halo2_bn254_gwc_halo2_verifier
tachyon_halo2_bn254_gwc_log_derivative_halo2_verifier
tachyon_halo2_bn254_shplonk_halo2_verifier
tachyon_halo2_bn254_shplonk_log_derivative_halo2_verifier
Instead of this complicated approach, this PR unifies the following to enable switching the lookup scheme:
tachyon_halo2_bn254_gwc_prover
tachyon_halo2_bn254_shplonk_prover
tachyon_halo2_prover
tachyon_halo2_bn254_gwc_verifier
tachyon_halo2_bn254_shplonk_verifier
tachyon_halo2_verifier
Description
The motivation behind this PR is to simplify the naming convention for supporting
halo2andlog_derivative_halo2lookups. Previously, we would need to create 8 C APIs as follows:tachyon_halo2_bn254_gwc_halo2_provertachyon_halo2_bn254_gwc_log_derivative_halo2_provertachyon_halo2_bn254_shplonk_halo2_provertachyon_halo2_bn254_shplonk_log_derivative_halo2_provertachyon_halo2_bn254_gwc_halo2_verifiertachyon_halo2_bn254_gwc_log_derivative_halo2_verifiertachyon_halo2_bn254_shplonk_halo2_verifiertachyon_halo2_bn254_shplonk_log_derivative_halo2_verifierInstead of this complicated approach, this PR unifies the following to enable switching the lookup scheme:
tachyon_halo2_bn254_gwc_proverandtachyon_halo2_bn254_shplonk_provertotachyon_halo2_provertachyon_halo2_bn254_gwc_verifierandtachyon_halo2_bn254_shplonk_verifiertotachyon_halo2_verifier