Closed ashjeong closed 2 months ago
@ashjeong Maybe fix(math): fix CosetFFTBatch bugs -> fix(math): fix CosetLDEBatch bugs ?
There are several places to use PackedField
, why did you just change some parts in chore(math): change PackedPrimeField to PackedField
refac
refac
refac
test
refac
refac
feat
field_merkle_tree_unittest.cc
to have members without std::unique_ptr<T>
?refac
. Also, is it possible to change it in clearer way? e.g, "move swapping methods to `evaluation_utils"?refac
.TDLR -> TLDR in 807c7355800600c4c744cfa67f779f17a8f12287 body
There are several places to use
PackedField
, why did you just change some parts in chore(math): change PackedPrimeField to PackedFieldThinking on it, I think all packed fields are packed prime fields. Since this is so, I'll drop this commit, but I think we'll need to standardize names in the future since we say
PackedF
,PackedField
, andPackedPrimeFields
, but they're all the same.
edit: on second thought, the change is still viable, but I'll simply change the name to limit it to my current scope of matrix_utils
fix(crypto): fix FieldMerkleTreeMMCS bug please remove pdqsort
from the file.
Please fix
Please remove chore(crypto): remove unneeded dependency since it removes the required dependency!
This PR implements TwoAdicFriPCS from Plonky3. See the reference here.