kroma-network / tachyon

Modular ZK(Zero Knowledge) backend accelerated by GPU
MIT License
7.77k stars 231 forks source link

feat: impl two adic fri pcs #492

Closed ashjeong closed 2 months ago

ashjeong commented 2 months ago

This PR implements TwoAdicFriPCS from Plonky3. See the reference here.

TomTaehoonKim commented 2 months ago

@ashjeong Maybe fix(math): fix CosetFFTBatch bugs -> fix(math): fix CosetLDEBatch bugs ?

chokobole commented 2 months ago

There are several places to use PackedField, why did you just change some parts in chore(math): change PackedPrimeField to PackedField

chokobole commented 2 months ago
dongchangYoo commented 2 months ago

TDLR -> TLDR in 807c7355800600c4c744cfa67f779f17a8f12287 body

ashjeong commented 2 months ago

There are several places to use PackedField, why did you just change some parts in chore(math): change PackedPrimeField to PackedField

Thinking on it, I think all packed fields are packed prime fields. Since this is so, I'll drop this commit, but I think we'll need to standardize names in the future since we say PackedF, PackedField, and PackedPrimeFields, but they're all the same.

edit: on second thought, the change is still viable, but I'll simply change the name to limit it to my current scope of matrix_utils

chokobole commented 2 months ago
chokobole commented 2 months ago

fix(crypto): fix FieldMerkleTreeMMCS bug please remove pdqsort from the file.

TomTaehoonKim commented 2 months ago

Please fix

  1. 02c829b "Add" -> "add"
  2. 08935ee "StrictLog2" -> "CheckedLog2"
chokobole commented 2 months ago

Please remove chore(crypto): remove unneeded dependency since it removes the required dependency!