search

kroma-network / tachyon

Modular ZK(Zero Knowledge) backend accelerated by GPU
MIT License
7.77k stars 231 forks source link

test(benchmark): add baby bear poseidon2 benchmark #519

Closed ashjeong closed 3 months ago

ashjeong commented 3 months ago

Whereas all other benchmarks display all vendors on the same graph, Plonky3 and Horizen compute values with a different internal matrix, requiring them to be compared with Tachyon separately.

chokobole commented 3 months ago

please add the scope benchmark to all the commits.

ashjeong commented 3 months ago

[Optional] how about changing the names of the files? from benchmark/poseidon2/poseidon2_benchmark_baby_bear_horizen_ubuntu_i9.png to benchmark/poseidon2/baby_bear_horizen_ubuntu_i9.png

Else, LGTM

I do agree with you that this would be better shortened in the way you mentioned; however the photos are named in this way across all other benchmark photos and the standard becomes convoluted especially with the fft benchmark folder which has fft_bencmark... and ifft_benchmark... photos. Perhaps it can be changed all together later!