kroma-network / tachyon

Modular ZK(Zero Knowledge) backend accelerated by GPU

MIT License

7.77k stars 231 forks source link

perf(math): optimize radix2 domain #521

Closed chokobole closed 2 months ago

chokobole commented 3 months ago

Description

This PR optimizes CosetLDEBatch() and IFFTBatch() in a high view.

batzor commented 2 months ago

In ef58cee, I think you meant refac(math): change CosetFFTBatch() to private -> refac(math): change CosetLDEBatch() to public

chokobole commented 2 months ago

In ef58cee, I think you meant refac(math): change CosetFFTBatch() to private -> refac(math): change CosetLDEBatch() to public

No, the methods were originally all public, and I changed CosetFFTBatch() to private because it's only used internally. So the change was intentional and correct.

batzor commented 2 months ago

LGTM