search

kroma-network / tachyon

Modular ZK(Zero Knowledge) backend accelerated by GPU
MIT License
7.77k stars 231 forks source link

feat: make `TwoAdicFriPcs` stateless #541

Closed chokobole closed 1 month ago

chokobole commented 2 months ago

Description

The reason for the failing sp1-core unittests is due to TwoAdicFriPcs having internal state while being run in a multithreaded environment, causing state corruption. The following states were identified:

By removing these states, the test passed, but this raises concerns about performance. OPENMP loops should ideally run on a single machine, even across different processes, to avoid potential performance issues. See https://github.com/kroma-network/tachyon/commit/0508297020cf2c8a0e6fa80af723e84e57b4870e

TomTaehoonKim commented 2 months ago

@chokobole Can you remove the "Since" in the beginning of the commit message of 0c63f4f and af10ea9? There's also since after the comma, so I think this way is much better.

dongchangYoo commented 1 month ago

There are typo in the commit messages: "breaing change -> breaking chanege" See commit bodies of 3279ce68797e635cee00aa07fe27c9e031268c1c, ced7ab8c60de5167af943489d1213cd6ddb62f5c