refac: clean up fri protocol & benchmarks - Githubissues

kroma-network / tachyon

Modular ZK(Zero Knowledge) backend accelerated by GPU

MIT License

7.77k stars 231 forks source link

refac: clean up fri protocol & benchmarks #551

Closed ashjeong closed 4 weeks ago

ashjeong commented 4 weeks ago

Fixes up minor typos and logic errors involved in FRI (+ benchmarks)

TomTaehoonKim commented 4 weeks ago

@ashjeong Can you fix ... to _ in ee4bc3f138a7e72f13d131386b276c4fb619d860?

ashjeong commented 4 weeks ago

@ashjeong Can you fix ... to _ in ee4bc3f?

Changed from ... to (inv)!

chokobole commented 4 weeks ago

I think if you change the code for better readability, we need to type it as a refac!

chore(crypto): fix variable name typo from ro_value to ro_values Please change it to refac(crypto)
chore(crypto): ensure shift is constant Please change it to refac(crypto)
fix(crypto): fix ComputeInverseDenominators faulty logic It's minor but it would be nice to change [See here.](link) to See here.`
chore(math): rename rev(inv)rootsvec to bitrev(inv_)roots_vec for better understandability Please change it to refac(crypto) and make it under 80 length
chore(crypto): remove unused type Please change it to refac(crypto)
chore(benchmark): fix lint errors Please change it to style(benchmark)