kromitgmbh / titra

titra - modern open source project time tracking for freelancers and small teams
https://titra.io
GNU Affero General Public License v3.0
406 stars 55 forks source link

Details View Dates Are Off by One Day #182

Closed CaptainPackers closed 1 year ago

CaptainPackers commented 1 year ago

The dates of items in the Details View are all a day early. I looked through all the settings for a time zone setting but could not find one. Can you please look into this? Thanks.

faburem commented 1 year ago

The way we deal with timezones in titra is that we are converting all dates to UTC, which is what we store in the backend. When we display date/time information we display it in the local timezone based on the browser setting. I will check if we missed such a conversion anywhere.

faburem commented 1 year ago

quick follow-up question - are your referring to the Detailed, Daily, Working time tab or all of them are showing the wrong date? Because I did find some missing utc conversions on the daily and working time tabs.

Thanks for your feedback!

CaptainPackers commented 1 year ago

I was originally referring to the Detailed tab, but I just looked at Daily and Working tabs and I now see that all of them are showing the wrong date. Thanks

Regards, Captain Packers-- Sent with Tutanota, enjoy secure & ad-free emails.

Jul 29, 2023, 7:57 AM by @.***:

quick follow-up question - are your referring to the Detailed, Daily, Working time tab or all of them are showing the wrong date? Because I did find some missing utc conversions on the daily and working time tabs.

Thanks for your feedback!

— Reply to this email directly, > view it on GitHub https://github.com/kromitgmbh/titra/issues/182#issuecomment-1656713933> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/ABYYL3KCVRQ3IOUHT6ARD3TXST3BNANCNFSM6AAAAAA23PZYYE> . You are receiving this because you authored the thread.> Message ID: > <kromitgmbh/titra/issues/182/1656713933> @> github> .> com>

faburem commented 1 year ago

Can you please let me know which timezone you are in and if your server and client are in different timezones? I am trying to reproduce this issue but haven't been successful so far.

faburem commented 1 year ago

Never mind - I figured it out. This seems to be a bug in the date library dayjs we are using behind the scenes (https://github.com/iamkun/dayjs/issues/1284). Luckily there are many workarounds described since this seems to be a known issue. Will be fixed in the next titra release!

CaptainPackers commented 1 year ago

Thanks

Regards, Captain-- Sent with Tutanota, enjoy secure & ad-free emails.

Aug 10, 2023, 8:09 AM by @.***:

Never mind - I figured it out. This seems to be a bug in the date library dayjs we are using behind the scenes (> iamkun/dayjs#1284 https://github.com/iamkun/dayjs/issues/1284> ). Luckily there are many workarounds described since this seems to be a known issue. Will be fixed in the next titra release!

— Reply to this email directly, > view it on GitHub https://github.com/kromitgmbh/titra/issues/182#issuecomment-1673097034> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/ABYYL3JIBBEDAZVGHFRF4ODXUTFOZANCNFSM6AAAAAA23PZYYE> . You are receiving this because you authored the thread.> Message ID: > <kromitgmbh/titra/issues/182/1673097034> @> github> .> com>

faburem commented 1 year ago

this should be fixed in the latest titra version 0.94.4. Can you please confirm so we can close this issue?

Thanks!

CaptainPackers commented 1 year ago

Confirmed. Please close this issue. Thank you. I love this app and appreciate your support.

Regards, Captain Packers-- Sent with Tutanota, enjoy secure & ad-free emails.

Aug 19, 2023, 9:05 AM by @.***:

this should be fixed in the latest titra version 0.94.4. Can you please confirm so we can close this issue?

Thanks!

— Reply to this email directly, > view it on GitHub https://github.com/kromitgmbh/titra/issues/182#issuecomment-1684939572> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/ABYYL3PKYN65EQVODRGNZDLXWC2ZFANCNFSM6AAAAAA23PZYYE> . You are receiving this because you authored the thread.> Message ID: > <kromitgmbh/titra/issues/182/1684939572> @> github> .> com>

faburem commented 1 year ago

You're very welcome, thanks for your kind feedback!