search

kronbichler / adaflo

adaflo, an adaptive finite element solver for incompressible fluid flow and two-phase flow
Other
24 stars 14 forks source link

Modify get_hypercube to fix compatibility issues with current deal.ii master #31

Closed mschreter closed 3 years ago

mschreter commented 3 years ago

I think this PR is related to https://github.com/dealii/dealii/pull/11602. Unfortunately, the change was "hard" so no deprecated warning popped up :-).

peterrum commented 3 years ago

I guess you have compiled the code successfully locally. If yes, I think the failing test here is related to the deal.II docker image being not up to date. If this is the case, feel free to merge!

mschreter commented 3 years ago

Yes, I was able to compile it locally. The docker image and the merging appeared almost at the same time. Let's wait a bit until the docker image will be updated.

peterrum commented 3 years ago

OK. I will restart the test in a couple of hours!

This is why I wrote on the slides of the workshop: "last resort". People should not use these function, they are meant primarily for internal usage (and for people who think they know what they do^^).

peterrum commented 3 years ago

The issue is more serious. All GitHub actions related to the Docker images fail: https://github.com/dealii/dealii/actions?query=workflow%3Agithub-docker

peterrum commented 3 years ago

Let's merge and I will sort out the issue tomorrow.

peterrum commented 3 years ago

@mschreter Btw, thanks a lot. I completely forgot that we are using this function...