Closed dktcoding closed 7 years ago
About the @Overrides
, I honestly started finding them useful when reading what other people wrote.
Regarding ResultSet
s, closing them becomes important with most cached drivers (like the latest driver for MariaDB), and when using connections pools where Connection#close()
actually releases the lease on the connection but doesn't actually close it.
I will check the resultset issues when i'm checking the DataSet refactors.
This are another unsorted changes, most of them have a reason to be:
Matrix#equals()
wasn't checking for type ornull
Map<String, Matrix>
when serializing multiple matrices, we need a proper implementation ofMatrix#hashCode()
to avoid problems when deserializing in differentlibai
instances (yes, the key of theMap
is aString
and not aMatrix
, but not all maps are deserialized the same way).MySQLDataSet
was mostly left alone, but no statement orResultSet
is being properly closed, I didn't touch it, because it uses theResultSet
itself inside the iterator and didn't have enough time to properly test it)NNIO
classserialVersionUID
to all serializable classes (I files serialized withlibai
compiled with OpenJDK don't work in versions compiled with OracleJDK because they lackserialVersionUID
... I tried... sigh)@Override
annotations, since I didn't writelibai
, it's fairly difficult to follow inherited methods (I'm sure that I'm not the only one).