kronenthaler / mod-pbxproj

A python module to manipulate XCode projects
MIT License
1.2k stars 294 forks source link

fix: support adding and removing Localizable.strings file #356

Open OmarIthawi opened 2 months ago

OmarIthawi commented 2 months ago

XCode project supports adding Localizable.strings file in multiple variants in which each language gets its own variant with the language code as the file "name" property.

Before

After

TODO

Fun fact

This code is written on Linux, with help from my colleagues to debug the version once it's ready on their iOS devices.

Thanks!

This project has been very helpful for us in openedx/openedx-app-ios. Thanks for creating it and double thanks for your fast triage for the other pull request.

OmarIthawi commented 2 months ago

@kronenthaler Thanks for the help on the other pull request. Would you mind enabling tests for "Second time contributors" like myself?

This can be done by selecting the "Require approval for first-time contributors" option as explained here:

OmarIthawi commented 2 months ago

Thanks @kronenthaler! I would appreciate a quick review before I go on and add tests for the new features I've built.

I really appreciate your help! I'm working on another opensource project and your help by both providing this project and traging pull requests has been remarkable.

OmarIthawi commented 1 month ago

@kronenthaler Would you mind sharing an update on how do we think we should proceed with this pull request?

kronenthaler commented 3 weeks ago

@kronenthaler Would you mind sharing an update on how do we think we should proceed with this pull request?

I will take a look somewhere this week and advise how to proceed.