kronihias / ambix

cross-platform Ambisonic VST, LV2 plug-ins with variable order for use in Digital Audio Workstations like Reaper or Ardour or as Jack standalone applications
GNU General Public License v2.0
235 stars 34 forks source link

Setting JucePlugin_LV2URI to a real URI. #28

Closed dvzrv closed 5 months ago

dvzrv commented 4 years ago

ambix_*/JuceLibraryCode/AppConfig.h: Switching from using 'JucePlugin_Name' as JucePlugin_LV2URI to a 'real' URI, so that lv2 hosts can actually discover and use the plugins and not crash on them.

Note: The URI does not have to be a 'real' URI (as in: an existing website), but needs to follow the established URI scheme to be recognized.

Closes #27

dvzrv commented 4 years ago

This doesn't fix the ambix_encoder_* plugins yet, as they currently still all have the same name due to the way the project is set up. It would be really great if the layout could be changed to acomodate for a unique URI per plugin also in that case.

dvzrv commented 4 years ago

Okay, by adding it to the respective CMakeLists.txt files I've made it work for the specific instances of ambix_encoder as well.

dvzrv commented 4 years ago

I realized I missed adding a definition for ambix_decoder. This is now also fixed!

dvzrv commented 4 years ago

@kronihias ping

dvzrv commented 5 months ago

@kronihias getting back to any of my tickets or merge requests would have been... the bare minimum.

I have spent considerable amounts of time just getting all of this to work to be able to provide this project as a package.

With the upgrade to 0.3.0 I can basically start all over again and by now I feel I'd rather just drop this project, as the time spent on it is seemingly not really appreciated by upstream.