search

krono / squeaksource3

Seaside-based Monticello code repository for Squeak, Pharo and GemStone
0 stars 0 forks source link

Unmigrated SSRepository returns #wrong rootUrl #55

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
After doit for Issue 47 is executed (during load step [1]), I run into trouble 
with the unmigrated instance of SSRepository ... #rootUrl message returns a 
String instead of a WAUrl instance ...

Need to either migrate SSRepository independent of other migrations or do all 
migrations during the same transaction that we're doing the load ...

Have to think on this one ..

[1] http://code.google.com/p/squeaksource3/wiki/UpgradeToDoSs3ToRc2

Original issue reported on code.google.com by henrichs...@gmail.com on 21 Dec 2011 at 12:46

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 21 Dec 2011 at 12:47

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 21 Dec 2011 at 12:51

GoogleCodeExporter commented 9 years ago 
It looks like SSRepository>>rootUrl is the only direct change to the behavior 
that appears to affect the running instances, so a patch to that method that 
returns a WAUrl instance might just work

Original comment by henrichs...@gmail.com on 21 Dec 2011 at 1:09

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Actually, if I remove SSRepository>>rootUrl we'll pick up the inherited 
implementation ... that's the ticket:)

Original comment by henrichs...@gmail.com on 21 Dec 2011 at 1:17

GoogleCodeExporter commented 9 years ago 
fixed in current workspace[1]

[1] http://code.google.com/p/squeaksource3/source/detail?r=209

Original comment by henrichs...@gmail.com on 21 Dec 2011 at 9:58

GoogleCodeExporter commented 9 years ago 
Of course not all of the senders of #rootUrl are expecting a WAUrl ... the 
unmigrated instances want a String ...

beginning to look like we'll have to try to migrate in same transaction as code 
load ...

Original comment by henrichs...@gmail.com on 21 Dec 2011 at 10:45

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 21 Dec 2011 at 11:28

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 22 Dec 2011 at 12:39

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 22 Dec 2011 at 12:40

GoogleCodeExporter commented 9 years ago 
back on track for separate load and migrate steps ...

Original comment by henrichs...@gmail.com on 22 Dec 2011 at 12:51

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 22 Dec 2011 at 12:52

GoogleCodeExporter commented 9 years ago 
See Issue 69 for new version of fix ... just fixing rootUrl was not quite enough

Original comment by henrichs...@gmail.com on 23 Dec 2011 at 6:55

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 23 Dec 2011 at 10:15