search

krono / squeaksource3

Seaside-based Monticello code repository for Squeak, Pharo and GemStone
0 stars 0 forks source link

SSProject>>fullDirectoryUrl wants old-style rootUrl #61

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Issue 55 fixed an issue where one code path expects new-style rootUrl (i.e., 
instance of WAUrl) ... but after load (before migrate) the code in unmigrated 
SSGemStoneProject instances was written to expect old-style rootUrl (i.e. 
Strings) ... 

this is the bug that broke the camel's back, as we'll need to migrate in same 
transaction as load...

Original issue reported on code.google.com by henrichs...@gmail.com on 21 Dec 2011 at 10:56

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 21 Dec 2011 at 11:29

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 21 Dec 2011 at 11:29

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 22 Dec 2011 at 12:40

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 22 Dec 2011 at 12:41

GoogleCodeExporter commented 9 years ago 
mokay ... making a stab at doing the load migrate in two separate transactions. 
adding an #asString to the affected methods just might fix this problem ...

Original comment by henrichs...@gmail.com on 22 Dec 2011 at 12:56

GoogleCodeExporter commented 9 years ago 
just a handful of methods send rootUrl ...

Original comment by henrichs...@gmail.com on 22 Dec 2011 at 1:11

GoogleCodeExporter commented 9 years ago 
These guys look like the most obvious badboys (#fullDirectoryUrl was the puppy 
that I hit):

  (SSGenericFrame compiledMethodAt: #updateRoot:)
  (SSProject compiledMethodAt: #fullDirectoryUrl)
  (SSSendPassword compiledMethodAt: #sendMailWithUrl:toMember:)

Original comment by henrichs...@gmail.com on 22 Dec 2011 at 5:49

GoogleCodeExporter commented 9 years ago 
SS3 project displays correctly in unmigrated state...Issue 60 still present...

Original comment by henrichs...@gmail.com on 22 Dec 2011 at 6:10