krono / squeaksource3

Seaside-based Monticello code repository for Squeak, Pharo and GemStone
0 stars 0 forks source link

RESTful links are empty noops #69

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
After upgrade but before migrate[1] none of the links for .cs, .diff, .mcz 
files or for the project listing work correctly ...  hitting the project 
without the .html suffix takes you to the overview page, not the WebDAV 
listing.. The .cs, .diff and .mcz links take you to the project page with no 
content...

[1] http://code.google.com/p/squeaksource3/source/detail?r=227

Original issue reported on code.google.com by henrichs...@gmail.com on 23 Dec 2011 at 5:31

GoogleCodeExporter commented 9 years ago
Looks like we need to use the latest version of SSUrlFilter class. Don't need 
to migrate in this case... we can surgically replace the instance:

    "Replace current urlFilter with a new one"
    | app urlFilter previous current newFilter |
    app := WADispatcher default handlerAt: 'ss'.
    urlFilter := app filters detect: [:each | each isKindOf: (Smalltalk at: #SSUrlFilter) ] ifNone: [ nil error: 'did not find url filter' ].
    newFilter := (Smalltalk at: #SSUrlFilter) new.
    previous := nil.
    current := app filter.
    [ current = app ] whileFalse: [
        current = urlFilter ifTrue: [
            newFilter setNext: current next.
            previous isNil
                ifTrue: [ app setFilter: newFilter ]
                ifFalse: [ previous setNext: newFilter ].
            ^ newFilter ].
        previous := current.
        current := current next ].
    nil error: 'Did not replace url filter'

This also fixes Issue 55...

Original comment by henrichs...@gmail.com on 23 Dec 2011 at 6:54

GoogleCodeExporter commented 9 years ago
fix included in[1] 

[1] http://code.google.com/p/squeaksource3/source/detail?r=229

Original comment by henrichs...@gmail.com on 23 Dec 2011 at 7:00

GoogleCodeExporter commented 9 years ago

Original comment by henrichs...@gmail.com on 23 Dec 2011 at 10:16