search

krono / squeaksource3

Seaside-based Monticello code repository for Squeak, Pharo and GemStone
0 stars 0 forks source link

Need to re-load patched sources of SqueakSource packages #97

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
When loading [UpgradeWorkspaceSs3ToRc2 with the script],
the following classes/methods are patched:
 # SSGenericFrame>>updateRoot:
 # SSProject>>fullDirectoryUrl
 # SSSendPassword>>sendMailWithUrl:
 # SSVersion>>changesUrl: 
 # SSVersion>>diffyUrl: 
 # SSVersion>>diffUrl
 # SSRepository>>wellKnownName
 # SSProject>>emailRecipients

After migration (Issue 46), these patches have to be undone, eg in the
cleanup phase (Issue 63).

Affected Monticello-packages: 
 # SqueakSource-Core
 # SqueakSource-Subscription-Email

These could be simply loaded again.
Metacello seems not to help here, as it thinks, 3.0-rc.1 is properly loaded
already and skips those. "ignoreImage:" is no option either.

Any thoughts?

Original issue reported on code.google.com by tobiasp...@gmail.com on 18 Jul 2012 at 1:23

GoogleCodeExporter commented 9 years ago

Original comment by tobiasp...@gmail.com on 18 Jul 2012 at 1:24

GoogleCodeExporter commented 9 years ago 
Sorry ... gmail has been "hijacking my emails" for awhile and I only just 
noticed ...

When you say "reloaded" what do you mean ... were they dirtied by some other 
package load or what?

Original comment by henrichs...@gmail.com on 27 Jul 2012 at 12:38

GoogleCodeExporter commented 9 years ago 
No, within the load script, we ptach the named methods to work on unmigrated 
instances of 
their classes. 

However, when these objects have been migrated, the hand-wired methods do not 
fit any longer and
SS3 would not work with migrated objects.

Original comment by tobiasp...@gmail.com on 27 Jul 2012 at 7:07

GoogleCodeExporter commented 9 years ago 
Sorry gmail continues to hijack my google mail ... perhaps I've finally fixed 
the problem?

Metacello is possibily not reloading because the packages are dirty, Metacello 
won't load over dirty packages ... if that's the case, there should be a 
Transcript message to the effect of "skipped dirty package" and there is a way 
to tell Metacello go ahead and load:

  [ ... ] on: MetacelloSkipDirtyPackageLoad do: [:ex | ex resume: false ]

should do the trick

Original comment by henrichs...@gmail.com on 29 Jul 2012 at 4:12