Closed uglrl closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.05%. Comparing base (
e49af4c
) to head (ab985dc
). Report is 4 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Ich hab das jetzt mal in die Datenbank hinzugefügt. Jetzt muss das "nur" noch im frontend angepasst werden.
Some statistics on the poultry regex matches on the existing unknown meals: We currently have 285 main dishes with unknown type (out of 1363 mains total). 178 of them match with the new regex. Of the remaining 107, most are either wrongly missing a category or have some sort of fish that maybe does not count under the mensa's fish category.
We also have "Hausgeräucherte Entenbrust mit Mango - Chili - Chutney" which should also include according to Wikipedia[1]. Some more meals we could include:
chicken
as a keyword
[1] https://en.wikipedia.org/wiki/Poultry@AlexKutschera do you know why the flutter tests are failing? Also, we need the frontend part of this so the app does not do unexpected things.
Note to myself @worldofjoni When deploying this, the database needs to be migrated
Es fehlt glaube ich noch der Geflügel Typ im GraphQL Schema: https://github.com/kronos-et-al/MensaApp/blob/f2ec05ac935773cb333cbfdcddfba97cff6433ec/backend/src/util.rs#L127-L145
Es fehlt glaube ich noch der Geflügel Typ im GraphQL Schema: No. You are referencing the wrong version. https://github.com/kronos-et-al/MensaApp/blob/ab985dcaa59909fe2a847bd2f6d2c8e50aaaf917/backend/src/util.rs#L143C1-L143C13
Make sure, you have done de following before merging this pull request:
cargo format
andcargo clippy
to format your code and check for improvements.