krontech / chronos-cam-app

Chronos Camera App
GNU General Public License v3.0
16 stars 6 forks source link

External Storage Device Browser #179

Closed DinoMalpera closed 3 years ago

DinoMalpera commented 3 years ago

Implementation of external storage browser. The browser is configurable but not extendable. It comes in two flavors: folder selection mode and file browse mode. System calls are used for filesystem operations.

Unicode is handled but not supported.

Note: asserts are used in the code - beware when building for release.

pengc1995 commented 3 years ago

Browser widget looks amazing. Colors are consistent with other sections in GUI. The style of scroll bar can be changed (see QTextEdit QScrollBar in stylesheets as reference).

DinoMalpera commented 3 years ago

Thank you Chelly. Yes, I've tried using the scroll bar style from QTextEdit and QScrollBar but it didn't work out; it looked weird (the bar didn't have the full range of motion) and it wasn't responsive - it was extremely difficult to get the scroll bar to move. I've found that the scollBar for resolution selection suffers from the same issue - it's almost impossible to scroll. ScrollBar for kickstarter on the other hand (QTextEdit) works flawlessly. After playing with it for hours I decided to leave it without the custom bar icon. :(

pengc1995 commented 3 years ago

Yes, I noticed the scroll bar for resolution selector had some problems. Within a few seconds of opening, it may be a little difficult to move. However, I can catch and move the handle after that, maybe my fingertip is tinier than yours. I once thought it was caused by the small size of the handle or margins. Anyway, it is not a big issue and we can try to find out why and fix it.