kronusaturn / lw2-viewer

An alternative frontend for LessWrong 2.0
https://www.greaterwrong.com/
MIT License
64 stars 6 forks source link

Provide public font URLs #15

Closed jimrandomh closed 5 years ago

jimrandomh commented 5 years ago

In lw2.lisp, there are some hardcoded URLs on fonts.greaterwrong.com. These don't quite match the URLs that the deployed instance of greterwrong requests; they're off by one level of URL encoding, and don't work.

achmizs commented 5 years ago

The deployed instance of GW in fact does request the hardcoded URLs, via a caching reverse proxy; they redirect to the modified URLs for cache-control reasons. So, the hardcoded URLs are correct, and function properly. However, I have now modified the font server to avoid unnecessary URL-encoding, to avoid confusion henceforth.

kronusaturn commented 5 years ago

The actual reason is that some of the fonts are proprietary, so we can't legally allow them to be served to arbitrary sites. Reopening this because we should provide an option to use only free fonts at some point.

jimrandomh commented 5 years ago

They do actually get served to arbitrary sites; if I adjust the URL schema in the code, they load.

kronusaturn commented 5 years ago

Fixed in 32be8d63..477c560f