kronusaturn / lw2-viewer

An alternative frontend for LessWrong 2.0
https://www.greaterwrong.com/
MIT License
64 stars 6 forks source link

Completely untested post.lisp change: use <main> #19

Closed adiabatic closed 5 years ago

adiabatic commented 5 years ago

This should help not-particularly-intelligent read-it-later parsers figure out what the important part of a post page is.

As a disclaimer, I'd like to publicly note that this change is completely untested and was written by someone whose last Lisp exposure was maybe two weeks of basic Clojure five years ago. If any CSS depends on this element being a div, then this change will break things. That said, I didn't see "div.post" anywhere in the dark-mode CSS.

adiabatic commented 5 years ago

Currently, Instapaper (and also possibly the Send To Kindle functionality elsewhere) mistakenly think that the important part of the page is #theme-tweaker-ui or thereabouts.

kronusaturn commented 5 years ago

Lucky guess, your untested code works :)