search

kronusaturn / lw2-viewer

An alternative frontend for LessWrong 2.0
https://www.greaterwrong.com/
MIT License
64 stars 6 forks source link

Add annotation preferences html #20

Closed JD-P closed 5 years ago

jimrandomh commented 5 years ago

Is there some context to this? I'm quite confused what this PR is supposed to be doing. It adds some configuration UI, but as far as I can tell there's no backend that would use or store these settings. And it seems to be something related to a third-party commenting service, but LW and GW already have commenting built in; we wouldn't want to split part of the conversation off to a place where most users won't get to see it.

JD-P commented 5 years ago

Is there some context to this? I'm quite confused what this PR is supposed to be doing. It adds some configuration UI, but as far as I can tell there's no backend that would use or store these settings. And it seems to be something related to a third-party commenting service, but LW and GW already have commenting built in; we wouldn't want to split part of the conversation off to a place where most users won't get to see it.

This is a feature for Whistling Lobsters 2.0, and has nothing to do with LessWrong 2 except that it'll lead to us eventually adding a page to change LW 2 user settings if the API permits it.

JD-P commented 5 years ago

This is a rough version of the final annotation display code/formatting, it should just need a few code tweaks and styling to be good to go.