kronusaturn
commented
2 years ago I think this is happening because the code that checks whether you've replied to comments in your inbox was written before tags could be commented on and blindly assumes that all comments are attached to a post. I made a quick fix to avoid the error (87404da2) but this code still needs to be rewritten to support tags.
ChickenProp
When I visit a specific page in my inbox, I don't get any content or pagination buttons, just an error message
The main layout renders fine, just the page content is broken. It looks like this:
Currently this happens for me on page 3. Previously it happened on page 2, and before that page 1. For a while I assumed this was related to #36 (which, thanks for fixing!) because it started at some point after I submitted that, and because at some point my page 1 started working again and my page 2 broke. But I didn't get around to saying anything about it, and I now think that was coincidence.
If I manually change the offset parameter in the URL, right now the page works at offset 27, breaks from offsets 28-49, and works again at offset 50. The top notification at offset 50 is the thumbs-up comment from #36, so I think that notification is fine and the one I got immediately after it is broken.
Offset 28 would render notiications numbered 28 through (28+19 = 47), so it seems like notifications 47, 48 and 49 are failing to render for me. And when I look at my LW inbox, indeed there are three that I can't see on GW:
The reply from farp is notification 50, and the second reply from Duncan (at the top) is 46, visible at offset 27. The first reply from Duncan (second from top), and the two comments on "dath ilan" (a tag page), aren't visible with any offset. The dath ilan notifications are weird on LW too: other notifications have a popup on the left when I hover over them, these don't. Also, I don't actually know why I received them.
My guess is that actually the first reply from Duncan is fine, and the dath ilan notifications are broken in such a way that they cause problems if they're on the current page or if they're the first notification on the next page? But I dunno if that fits with how the API works.
Links:
farp's comment (notification works) Kenny's comment (notification not visible) Pattern's comment (notification not visible) Duncan's first comment (notification not visible) Duncan's second comment (notification works)