kroshu / kuka_drivers

Repository containing ROS2 drivers for multiple KUKA robots
Apache License 2.0
78 stars 23 forks source link

Fix/initial control mode #92

Closed altex111 closed 1 year ago

altex111 commented 1 year ago

The problem was solved with a premature fix. The decision was to resolve the issue with a more finetuned solution later

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Svastits commented 1 year ago

I can only write a comment here for some reason... If you configure, activate, deactivate and activate again, the control mode handler will not be active IMO You should separate it from the controller_handler and simply activate in configure transition and deactivate in cleanup